Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying and saving this file did not pin it #7154

Closed
Tyriar opened this issue Jun 2, 2016 · 5 comments
Closed

Modifying and saving this file did not pin it #7154

Tyriar opened this issue Jun 2, 2016 · 5 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority info-needed Issue requires more information from poster verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone
June 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2016

Version 1.2.0-alpha
Commit 81ab7e3
Date 2016-05-31T18:40:39.797Z
Ubuntu 16.04

Not sure what I did in particular but it is not in this state:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench workbench-tabs VS Code editor tab issues labels Jun 2, 2016
@Tyriar Tyriar changed the title Modifying this file did not pin it Modifying and saving this file did not pin it Jun 2, 2016
@bpasero
Copy link
Member

bpasero commented Jun 3, 2016

@Tyriar really need some steps to reproduce here to find out. What is odd is that the file is dirty and even that is not showing in the editor.

I am moving this back to you to try out more things: Did you maybe have the same file open in multiple groups and stuff like that?

@bpasero bpasero assigned Tyriar and unassigned bpasero Jun 3, 2016
@bpasero bpasero added this to the June 2016 milestone Jun 3, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2016

@bpasero if I manage to reproduce I'll ping this.

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 3, 2016
@bpasero
Copy link
Member

bpasero commented Jun 4, 2016

@Tyriar I just ran into this too, super weird. Gotta find steps to reproduce...

@bpasero bpasero assigned bpasero and unassigned Tyriar Jun 4, 2016
@bpasero bpasero added the important Issue identified as high-priority label Jun 4, 2016
@bpasero
Copy link
Member

bpasero commented Jun 4, 2016

Ok I got it, needs some serious fixing.

@bpasero bpasero closed this as completed in fb0efa5 Jun 6, 2016
@bpasero bpasero assigned Tyriar and unassigned bpasero Jun 6, 2016
@bpasero
Copy link
Member

bpasero commented Jun 6, 2016

This reproduced for me quite easily like this: open file, close file, use quick open to pick the file again from history and start typing: no pinning or dirty indication at all.

aeschli pushed a commit that referenced this issue Jun 6, 2016
@bpasero @aeschli
Modifying and saving this file did not pin it (fixes #7154)
5af8ecb
@jrieken jrieken added the verified Verification succeeded label Jul 4, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority info-needed Issue requires more information from poster verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
3 participants
@bpasero @jrieken @Tyriar