New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSBuffer#toString returns numbers #71993

Closed

jrieken opened this issue Apr 9, 2019 · 1 comment

Assignees

Labels

bug important verified

Milestone

Member

jrieken commented Apr 9, 2019

inside a context with support for Buffer
create a VSBuffer from an Uint8Array array, e.g. VSBuffer.wrap(new Uint8Array(data, 0, 12))
call toString on the VSBuffer
🐛 numbers, not a string, are return because the implementation simply calls buffer.toString

The text was updated successfully, but these errors were encountered:

jrieken assigned alexdima

Member

alexdima commented Apr 9, 2019

Nice catch!

alexdima added this to the April 2019 milestone

alexdima added bug important labels

alexdima closed this as completed in

f3e1c7d

jrieken added the verified label

vscodebot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.