Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize Webview port mapping api #72152

Closed
mjbvz opened this issue Apr 11, 2019 · 4 comments
Closed

Finalize Webview port mapping api #72152

mjbvz opened this issue Apr 11, 2019 · 4 comments
Assignees
@mjbvz
Labels
api-finalization webview Webview issues
Milestone
April 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 11, 2019

Tracks finalizing the webview port mapping API proposed in #70851
@mjbvz mjbvz added this to the April 2019 milestone Apr 11, 2019
@mjbvz mjbvz self-assigned this Apr 11, 2019
@mjbvz mjbvz changed the title Finalize Webview portmapping api Finalize Webview port mapping api Apr 11, 2019
@jrieken
Copy link
Member

jrieken commented Apr 15, 2019

How about names: webviewPort and extensionHostPort? That would name them according to the places at which the ports are being listened on

@mjbvz
Copy link
Contributor Author

mjbvz commented Apr 15, 2019

/cc @Chuxel

@Chuxel
Copy link
Member

Chuxel commented Apr 15, 2019

@jrieken @mjbvz I like the proposal, but I'd rather not change the names if we can help it given uptake by extension authors to date. Could we support both sets for backwards compatibility?

@mjbvz
Copy link
Contributor Author

mjbvz commented Apr 15, 2019

We're going to change the names to what @jrieken suggests but keep compatibility with the existing names for an iteration

@mjbvz mjbvz closed this as completed in 94ba9cf Apr 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api-finalization webview Webview issues
Projects
None yet
Milestone
April 2019
Development

No branches or pull requests
3 participants
@Chuxel @jrieken @mjbvz