Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes the Markdown preview stops updating #72671

Closed
EFanZh opened this issue Apr 21, 2019 · 7 comments
Closed

Sometimes the Markdown preview stops updating #72671

EFanZh opened this issue Apr 21, 2019 · 7 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities markdown Markdown support issues *not-reproducible Issue cannot be reproduced by VS Code Team member as described
Milestone
Backlog

Comments

@EFanZh
Copy link
Contributor

EFanZh commented Apr 21, 2019

Issue Type: Bug

Sometimes the Markdown preview stops updating when I am typing if the source document is very large.

It is not easy to reproduce, but when it happens, it is very annoying.

Here is a video clip to describe what happened:

markdown-preview

Notice that at the end, no matter how long I wait, the preview never updates (two rs are missing from the preview). It is acceptable if the preview has some delay if the source document is very large, but this seems like some scheduling issue that the final updates from the source document is ignored.

The preview should be updated to match the source document if I wait long enough.

VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9800X CPU @ 3.80GHz (16 x 3792)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 63.68GB (51.96GB free)
Process Argv --disable-extensions
Screen Reader no
VM 0%
Extensions disabled
@vscodebot vscodebot bot added the markdown Markdown support issues label Apr 21, 2019
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Apr 24, 2019
@skprabhanjan
Copy link
Contributor

@EFanZh , Yes this is happening and I think this happens in the case when you change something and then wait for like 2/3 seconds and change something again and similarly repeat it or stop, Just changing once seems to be working but takes some time.
@mjbvz , I think the refresh preview calls are getting clogged because of the way the user is updating the markdown document , Can you please confirm any way we can fix this ?

@skprabhanjan skprabhanjan mentioned this issue Apr 25, 2019
Closed
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 29, 2019
@mjbvz
Check pending version before updating markdown preview content
4470b86 
For microsoft#72671
@mjbvz mjbvz mentioned this issue Apr 29, 2019
Merged
@mjbvz
Copy link
Contributor

mjbvz commented Apr 29, 2019 •
edited

@skprabhanjan Thanks looking into this. I'm having trouble reproducing this issue but there are two places where I believe that updates to the preview could be getting out of sync:

  1. In the call to doUpdate itself:

    vscode/extensions/markdown-language-features/src/features/preview.ts

    Line 415 in 312b09c

    }
    We're currently stabilizing vscode's master branch so I can't check this in but here's a PR that should the problem: Double check pending markdown version before updating preview #73049

  2. In the updates to the webview content itself. Here's the code that runs inside the webview that does the update:

    vscode/src/vs/workbench/contrib/webview/browser/pre/main.js

    Line 239 in fbf201b

    const options = data.options;

If you can reproduce this problem, try taking a look the PR and try it out on your local machine to see if it fixes this.

@skprabhanjan
Copy link
Contributor

skprabhanjan commented May 3, 2019 •
edited

@mjbvz , Not sure exactly how to fix this as the issue is not consistent and when I checked it today, it seems to work ( but surely the preview refresh and sync takes some time, which is considerable for that large file) , So I leave it open for you to take a call on this.
I would suggest @EFanZh to check it again and give it some time to update.

@mjbvz mjbvz added this to the May 2019 milestone May 10, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 10, 2019 •
edited

@EFanZh Please test this again on the VS Code 1.35 insiders builds that should be coming out at the end of next week

@mjbvz
Copy link
Contributor

mjbvz commented May 17, 2019

@EFanZh New insiders builds are out. Can you please test this again using them

@EFanZh
Copy link
Contributor Author

EFanZh commented May 18, 2019 •
edited

It seems the problem still exists:

image

The last letter t is missing from the preview.

@mjbvz mjbvz modified the milestones: May 2019, Backlog May 24, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Sep 27, 2019

I'm closing this given that no one else has reported this issue and no one on the vs code team can reproduce it either

@EFanZh Please investigate and submit a fix if you are consistently running into this. I've linked to most of the relevant code locations

@mjbvz mjbvz closed this as completed Sep 27, 2019
@mjbvz mjbvz added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Sep 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities markdown Markdown support issues *not-reproducible Issue cannot be reproduced by VS Code Team member as described
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@EFanZh @mjbvz @skprabhanjan