Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find all references in CSS cuts off before hyphen in property name #7292

Closed
dstorey opened this issue Jun 7, 2016 · 2 comments
Closed

Find all references in CSS cuts off before hyphen in property name #7292

dstorey opened this issue Jun 7, 2016 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2016

Comments

@dstorey
Copy link
Member

dstorey commented Jun 7, 2016

  • VSCode Version:
    Version 1.2.0 (1.2.0)
  • OS Version:
    OS X 10.lostCount

Steps to Reproduce:

  1. Right click on a CSS property value
  2. Find all occurrences

Expected:

See all of the property name as even the longest CSS properties are not that long

Actual:

It seems in most cases it trims before the last hyphen, but sometimes it keeps a little more.

This is probably a design decision (to keep the values aligned?) but I thought I'd file a bug as the property a value is defined on is often relevant, and many different properties end with the same last word (background-color, color, boder-left-color; background-image, border-image, etc.), and with CSS properties not being super long, there is often room to fit the full property. In the screenshot it even includes the comment.

screen shot 2016-06-06 at 9 24 16 pm
@aeschli aeschli assigned jrieken and unassigned aeschli Jun 7, 2016
@jrieken jrieken added the editor label Jun 7, 2016
@jrieken
Copy link
Member

jrieken commented Jun 7, 2016

Yeah, we cut the left part of a preview to roughly eight characters and prefer word boundaries, such as ., -, whitespace etc. I see how this isn't right for css. Maybe we shouldn't use /\b/ but a custom set of splitters

@jrieken jrieken added this to the June 2016 milestone Jun 7, 2016
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jun 7, 2016
@jrieken jrieken closed this as completed in 1429ec0 Jun 7, 2016
@jrieken
Copy link
Member

jrieken commented Jun 7, 2016

screen shot 2016-06-07 at 12 08 27

I am now using the word definition knowledge each language provides. That results in better cuts.

@roblourens roblourens added the verified Verification succeeded label Sep 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
4 participants
@roblourens @dstorey @jrieken @aeschli