Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action for toggling editor group maximize #72968

Closed
akbyrd opened this issue Apr 27, 2019 · 1 comment
Closed

Add action for toggling editor group maximize #72968

akbyrd opened this issue Apr 27, 2019 · 1 comment
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone
August 2019

Comments

@akbyrd
Copy link
Contributor

akbyrd commented Apr 27, 2019

We have actions to maximize an editor group and to reset editor groups sizes: workbench.action.minimizeOtherEditors and workbench.action.evenEditorWidths but there's no way to bind these is such a way that the same keybinding can toggle between maximized and not maximized.

I'd like to request an action such as workbench.action.toggleEditorGroupMaximize.

This is related to #24163 but I think is a better solution.
@akbyrd akbyrd mentioned this issue Apr 27, 2019
Closed
@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window workbench-editor-grid Grid layout issues in the editor area and removed workbench-editors Managing of editor widgets in workbench window labels Apr 29, 2019
@bpasero bpasero removed their assignment Apr 29, 2019
@bpasero
Copy link
Member

bpasero commented Aug 9, 2019

I pushed a new action "Toggle Editor Group Sizes" with command ID workbench.action.toggleEditorWidths that will:

  • maximize the active editor group unless maximized already
  • even out the editor widths otherwise

@bpasero bpasero self-assigned this Aug 9, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 9, 2019
@bpasero bpasero closed this as completed Aug 9, 2019
@akbyrd akbyrd mentioned this issue Aug 15, 2019
Closed
@chrisdias chrisdias mentioned this issue Aug 17, 2019
Closed
8 tasks
@bpasero bpasero added the verification-needed Verification of issue is requested label Aug 24, 2019
@mjbvz mjbvz added the verified Verification succeeded label Aug 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
3 participants
@akbyrd @bpasero @mjbvz