-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: switch to octicons for all icons in the status bar #74285
Comments
@misolori can you give me a hint where we are using the gear icon and where we are using the download icon? I could only find the task icons and smiley. PS: we would also need an info icon, tasks can show info/warning/error. |
I got the gear from the tasks folder here: https://github.com/microsoft/vscode/tree/master/src/vs/workbench/contrib/tasks/common/media It appears though that it's used in the quick pick only. I also didn't realize we already have a gear in Octicons so I can remove this. The download/task icon is from here:
I've seen that task icon before but can't get it to come up again, maybe @alexr00 can tell us. For the info, can we use the existing |
@misolori yeah I guess we can use existing icons for that |
I don't see the download/task icon used anywhere. |
Verification: there are no more SVGs used in the status bar, specifically:
|
/cc @dbaeumer @alexr00 on 8c35807 and af9cd4e. The task related status bar contributions are no longer in need to render the full contents, rather they now use the more lightweight The biggest change was around the status bar entry for showing errors, warnings and infos. Previously this where a couple of HTML elements / icons, and now it is just one label with octicons. I tried to preserve the behaviour we currently have. One thing to reconsider is to maybe move the "Building..." decoration that seems to be there when a task is active out. We have a progress service that can render progress messages on the status bar. Maybe you could give it a quick smoke test and verify the experience is still OK for you. |
Will make sure I have an eye on it the next days. |
Thanks, just fyi the fact that the info icon is not right is already covered in #74510 (comment) |
I've taken a look at the task use of the status bar and it still looks ok! |
This ensures that everything in the status bar is nicely aligned. Currently I always feel like the problems entry as well as the "Send Feedback" smiley are not aligned properly:
Steps:
PR: 350708a
The text was updated successfully, but these errors were encountered: