Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug status should be IStatusbarEntry #74455

Closed
bpasero opened this issue May 28, 2019 · 3 comments
Closed

Debug status should be IStatusbarEntry #74455

bpasero opened this issue May 28, 2019 · 3 comments
Assignees
Labels
debt Code quality issues workbench-status Status bar
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 28, 2019

I noticed that DebugStatus is a IStatusbarItem. This one is typically when you need full control over the rendering of the item, but it seems you are only using text and an icon we probably already have in our octicon set. I suggest to change this to IStatusbarEntry and use IStatusbarService#addEntry() to show and hide it dynamically. You can also update properties dynamically on the returned object.

If the icon is missing we can add it to our set. Just using icons from our octicon set ensures that they all look good when compared to each other.

//cc @misolori

@bpasero bpasero added debt Code quality issues workbench-status Status bar labels May 28, 2019
@isidorn
Copy link
Contributor

isidorn commented May 28, 2019

Makes sense, let's do this next week in debt week.

@isidorn isidorn added this to the June 2019 milestone May 28, 2019
@isidorn
Copy link
Contributor

isidorn commented Jun 4, 2019

Much cleaner now 🙌

@isidorn isidorn closed this as completed in 640e3f1 Jun 4, 2019
@bpasero
Copy link
Member Author

bpasero commented Jun 4, 2019

@isidorn thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues workbench-status Status bar
Projects
None yet
Development

No branches or pull requests

2 participants