Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keytar is a layer breaker #74997

Closed
jrieken opened this issue Jun 6, 2019 · 7 comments
Closed

Keytar is a layer breaker #74997

jrieken opened this issue Jun 6, 2019 · 7 comments
Assignees
@jrieken
Labels
debt Code quality issues important Issue identified as high-priority web Issues related to running VSCode in the web
Milestone
June 2019

Comments

@jrieken
Copy link
Member

jrieken commented Jun 6, 2019

See

vscode/src/vs/workbench/api/browser/mainThreadKeytar.ts

Lines 24 to 26 in 078da2b

// tslint:disable-next-line:import-patterns
this._keytar = import('keytar')
.catch(e => null);

This needs a different solution, something like a credentials service with some implementation for the web.

cc @bpasero
@jrieken jrieken added this to the June 2019 milestone Jun 6, 2019
@jrieken jrieken added debt Code quality issues web Issues related to running VSCode in the web labels Jun 6, 2019
@jrieken
Copy link
Member Author

jrieken commented Jun 6, 2019

Volunteers? @chrmarti

@jrieken jrieken added the important Issue identified as high-priority label Jun 6, 2019
@bpasero
Copy link
Member

bpasero commented Jun 6, 2019

Yes this sounds like a candidate for yet another service for that matter, ideally async.

@chrmarti
Copy link
Contributor

chrmarti commented Jun 7, 2019

@jrieken I don't know why this was put in browser.

@bpasero Could you tell me where the different pieces for a service should go? Like an example I can copy from.

@jrieken
Copy link
Member Author

jrieken commented Jun 7, 2019 •
edited

@alexandrudima moved this here, probably an oversight. I just pushed a fix for this, adding a credentials service, having an implementation for node-only

jrieken added a commit that referenced this issue Jun 7, 2019
@jrieken
fix layer breaker with credentials service, #74997
5f91328
@jrieken
Copy link
Member Author

jrieken commented Jun 7, 2019

For the future we should look into this new, emerging API https://developer.mozilla.org/en-US/docs/Web/API/Credential_Management_API

@jrieken jrieken closed this as completed Jun 7, 2019
@bpasero
Copy link
Member

bpasero commented Jun 7, 2019

Thanks 👍

@jrieken
Copy link
Member Author

jrieken commented Jun 7, 2019

interesting read: https://blog.arnellebalane.com/the-credential-management-api-7eb5650d23ca

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues important Issue identified as high-priority web Issues related to running VSCode in the web
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
3 participants
@bpasero @jrieken @chrmarti