Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration not loaded since conversion to use URI #75109

Closed
sbatten opened this issue Jun 8, 2019 · 0 comments
Closed

Configuration not loaded since conversion to use URI #75109

sbatten opened this issue Jun 8, 2019 · 0 comments
Assignees
@sandy081
Labels
config VS Code configuration, set up issues important Issue identified as high-priority
Milestone
June 2019

Comments

@sbatten
Copy link
Member

sbatten commented Jun 8, 2019

Issue Type: Bug

Since commit 70d9efe, the configuration is not being loaded at least on windows in the main process. I am not sure if other processes have the same issue. Using .path from URI is resulting in /C:/Users/... which isn't interpreted properly by the configuration service. Using .fsPath fixes the issue, but not sure if this is the proper fix or where else things are breaking.

VS Code version: Code - Insiders 1.36.0-insider (c089daa, 2019-06-07T05:19:15.188Z)
OS version: Windows_NT x64 10.0.18362
@sbatten sbatten added the important Issue identified as high-priority label Jun 8, 2019
@sbatten sbatten added this to the June 2019 milestone Jun 8, 2019
@sandy081 sandy081 added the config VS Code configuration, set up issues label Jun 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
config VS Code configuration, set up issues important Issue identified as high-priority
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
2 participants
@sbatten @sandy081