Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactors don't work on new javascript files #75132

Closed
adelphes opened this issue Jun 8, 2019 · 2 comments
Closed

Some refactors don't work on new javascript files #75132

adelphes opened this issue Jun 8, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) javascript JavaScript support issues typescript Typescript support issues

Comments

@adelphes
Copy link

adelphes commented Jun 8, 2019

  • VSCode Version:1,35
  • OS Version: Ubuntu 19.04 x64

Steps to Reproduce:

  • Launch a new, empty instance of VSCode
  • Create (but don't save) a new file (Untitled-1)
  • Set the language mode for the file to JavaScript (to enable the Typescript/Javascript language feature extension)
  • In the new file, type an arrow function with an unused parameter:
a => 3

Move cursor over a and from the "lightbulb" code actions, pick remove declaration from 'a' - it works;

() => 3

Now pick another code action: add braces to arrow function and nothing happens. Developer logs show:
image

Save the file (Untitled-1.js). Run the same code action again and it works:

() => {
	return 3;
}
@vscodebot vscodebot bot assigned mjbvz Jun 8, 2019
@vscodebot vscodebot bot added the javascript JavaScript support issues label Jun 8, 2019
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) typescript Typescript support issues labels Jun 10, 2019
@mjbvz mjbvz closed this as completed in a1c33c6 Jun 10, 2019
@adelphes
Copy link
Author

Hi @mjbvz - if you're opting to close an issue marked as a bug, could you include a brief note as to why it's being closed so that I (and others) can understand the reason. - thanks.

@mjbvz
Copy link
Contributor

mjbvz commented Jun 12, 2019

Because it was fixed; see the linked change

And please test in VS in vscode insiders

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

2 participants