Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.999.0 tag keeps getting added #75639

Closed
Tyriar opened this issue Jun 17, 2019 · 11 comments
Closed

1.999.0 tag keeps getting added #75639

Tyriar opened this issue Jun 17, 2019 · 11 comments
Assignees
@octref
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2019

Context: 5124506
@Tyriar Tyriar added this to the June 2019 milestone Jun 17, 2019
Tyriar referenced this issue Jun 17, 2019
@Tyriar
Simplify terminal logging
5124506
@octref octref added the engineering VS Code - Build / issue tracking / etc. label Jun 18, 2019
@octref
Copy link
Contributor

octref commented Jun 20, 2019

This should be fine now.

@octref octref closed this as completed Jun 20, 2019
@ghost
Copy link

ghost commented Jun 20, 2019

I am so sorry to repeat myself but the tag exists again. Or have you changed something else?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 20, 2019

@octref I wouldn't have thought people would be pushing tags mid iteration 😕

@Tyriar Tyriar reopened this Jun 20, 2019
@octref
Copy link
Contributor

octref commented Jun 21, 2019 •
edited

@Tyriar The problem is I introduced a plague. Some of us might default to push with --all or --tags. When he pushes 1.999.0 back, everyone who pull will get the tag again...

I guess I'll create an Azure build that sends a warning in Slack when the tag gets pushed again.
If at a moment none of the tag-pushers have 1.999.0 tag locally and 1.999.0 doesn't exist on GitHub, the plague can be cured!

@ghostium Very sorry about this, I guess it'll take us a few days to clean the tags out...

@octref
Copy link
Contributor

octref commented Jun 25, 2019

After talking to GH support I know who's pushing the tag. I have messaged him and we should be good.

@octref octref closed this as completed Jun 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 10, 2019

It's back

@Tyriar Tyriar reopened this Aug 10, 2019
@microsoft microsoft unlocked this conversation Aug 10, 2019
@Tyriar Tyriar removed this from the June 2019 milestone Aug 10, 2019
@octref octref added this to the August 2019 milestone Aug 10, 2019
@octref
Copy link
Contributor

octref commented Aug 10, 2019

Emailed GH support again. Lesson learned, will NEVER push a tag just for testing in the future...

@octref
Copy link
Contributor

octref commented Aug 10, 2019

Found the guilty one, messaged him so his local tag is gone. I deleted the remote tag as well.

@octref octref closed this as completed Aug 10, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 10, 2019

Well I have it now as well because I've pulled since it was added, so the next time myself or anyone else is the endgame master it back would be pushed back?

@octref
Copy link
Contributor

octref commented Aug 11, 2019

So there could be timed bombs on anyone's machine...
OK, I'll make a bot that post a message any time this tag is pushed.

@octref octref reopened this Aug 11, 2019
@octref octref modified the milestones: August 2019, On Deck Aug 27, 2019
@octref
Copy link
Contributor

octref commented Sep 3, 2019 •
edited

Now I have a bot that would notify everyone if 1.999.0 is pushed again.

@octref octref closed this as completed in b038107 Sep 3, 2019
octref added a commit that referenced this issue Sep 3, 2019
@octref
Merge pull request #80272 from microsoft/pine/1.999.0-bot
ed4a732 
Fix #75639
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 18, 2019
@octref octref removed this from the On Deck milestone Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @octref