Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Ctrl/Cmd + Click does not trigger port forwarding #76175

Closed
chrmarti opened this issue Jun 26, 2019 · 4 comments
Closed

Terminal: Ctrl/Cmd + Click does not trigger port forwarding #76175

chrmarti opened this issue Jun 26, 2019 · 4 comments
Assignees
@Tyriar @mjbvz
Labels
feature-request Request for new features or functionality on-testplan remote Remote system operations issues terminal Integrated terminal issues
Milestone
September 2019

Comments

@chrmarti
Copy link
Contributor

When Ctrl-/Cmd-clicking in a remote terminal the port forwarding that openExternal() is using should trigger too.
@mjbvz mjbvz added the feature-request Request for new features or functionality label Jun 26, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2019

I'm not sure what this means:

the port forwarding that openExternal() is using should trigger too.

@chrmarti
Copy link
Contributor Author

@mjbvz has added functionality to openExternal() that starts port forwarding when called on the remote extension host with a localhost http/s URL, so the browser on the host machine can reach the port on the remote side.

For remote terminals the same port forwarding could be applied, so localhost http/s URLs work when Ctrl-/Cmd-clicking them to open.

@Tyriar Tyriar added terminal Integrated terminal issues remote Remote system operations issues labels Jun 27, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2019

@mjbvz do you have a link to the code?

@mjbvz
Copy link
Contributor

mjbvz commented Jun 27, 2019

vscode/src/vs/workbench/api/browser/mainThreadWindow.ts

Line 51 in 0358d08

if (options.allowTunneling && !!this.environmentService.configuration.remoteAuthority) {

We could consider moving this logic to a higher layer in the code, such as the opener service

@Tyriar Tyriar mentioned this issue Jul 6, 2019
Closed
@Tyriar Tyriar added this to the Backlog milestone Jul 6, 2019
@mjbvz mjbvz modified the milestones: Backlog, September 2019 Sep 20, 2019
@mjbvz mjbvz closed this as completed in 6710df4 Sep 21, 2019
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 21, 2019
@mjbvz mjbvz added on-testplan and removed verification-needed Verification of issue is requested labels Sep 30, 2019
@mjbvz mjbvz mentioned this issue Sep 30, 2019
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality on-testplan remote Remote system operations issues terminal Integrated terminal issues
Projects
None yet
Milestone
September 2019
Development

No branches or pull requests
3 participants
@Tyriar @chrmarti @mjbvz