Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish which workspace folder a symbol belongs to in Ctrl-T search for symbol (Go To Symbol) #76661

Closed
johnnytemp opened this issue Jul 5, 2019 · 7 comments
Closed

Distinguish which workspace folder a symbol belongs to in Ctrl-T search for symbol (Go To Symbol) #76661

johnnytemp opened this issue Jul 5, 2019 · 7 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded workspace-symbols
Milestone
March 2020

Comments

@johnnytemp
Copy link

johnnytemp commented Jul 5, 2019 •
edited

When I Ctrl-T & type Abc (a class) to search for a symbol, it now show 3 symbols that I cannot distinguish like this :

Abc - <namespace> - abc.php
Abc - <namespace> - abc.php
Abc - <namespace> - abc.php

This is because my workspace have 3 folders (project), and each with the same class Abc (but in different folders on disk). Could you consider adding the workspace folder hinting like this (when the workspace have multiple workspace folders) so that I can distinguish the three? E.g.

Abc - <namespace> - abc.php (workspace_folder_1)
Abc - <namespace> - abc.php (workspace_folder_2)
Abc - <namespace> - abc.php (workspace_folder_3)

Remark: I think this scenario is quite common and so fired this request.
@vscodebot
Copy link

vscodebot bot commented Jul 5, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the php PHP support issues label Jul 5, 2019
@johnnytemp
Copy link
Author

johnnytemp commented Jul 5, 2019 •
edited

For your info: I'm using "PHP Intelephense" for the symbols' intellisense.

@roblourens roblourens assigned mjbvz and unassigned roblourens Jul 5, 2019
@roblourens roblourens removed the php PHP support issues label Jul 5, 2019
@mjbvz mjbvz added the *caused-by-extension Issue identified to be caused by an extension label Jul 8, 2019
@vscodebot
Copy link

vscodebot bot commented Jul 8, 2019

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jul 8, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Jul 8, 2019 •
edited

How the results are displayed is up to the extension that provides these results. Please file this issue against PHP Intelephense

@bmewburn
Copy link

bmewburn commented Jul 8, 2019

@mjbvz that's not entirely true. VSCode adds the filename to the result -- abc.php in this case. To solve this in the extension would mean to either only show the file that matches the currently active editor folder -- it's a workspace search not a folder search though -- or to hijack the SymbolInformation.containerName property which usually has namespace/typename info.

@mjbvz mjbvz assigned bpasero and unassigned mjbvz Jul 8, 2019
@mjbvz mjbvz removed the *caused-by-extension Issue identified to be caused by an extension label Jul 8, 2019
@mjbvz mjbvz reopened this Jul 8, 2019
@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues workspace-symbols labels Jul 9, 2019
@bpasero bpasero removed their assignment Jul 9, 2019
@bmewburn bmewburn mentioned this issue Jul 10, 2019
Closed
@jrieken jrieken self-assigned this Oct 22, 2019
@jrieken jrieken added this to the Backlog milestone Oct 23, 2019
@bpasero bpasero assigned bpasero and unassigned jrieken Mar 14, 2020
@bpasero bpasero modified the milestones: Backlog, March 2020 Mar 14, 2020
bpasero added a commit that referenced this issue Mar 14, 2020
@bpasero
quick access - always show relative path in symbol picker (fix #76661)
8a84894
@bpasero bpasero added the verification-needed Verification of issue is requested label Mar 16, 2020
@bpasero bpasero removed the verification-needed Verification of issue is requested label Mar 16, 2020
@bpasero bpasero added the verification-needed Verification of issue is requested label Mar 28, 2020
@bpasero
Copy link
Member

bpasero commented Mar 28, 2020

Verification
Open the workspace symbol search (Cmd+T) and find symbols. Verify their file path appears as part of the container description label.

@johnnytemp
Copy link
Author

johnnytemp commented Mar 29, 2020 •
edited

Verified the file path exists and can distinguish now. Thank you.

@bpasero bpasero added the verified Verification succeeded label Mar 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded workspace-symbols
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
6 participants
@roblourens @bpasero @jrieken @johnnytemp @bmewburn @mjbvz