Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-integration scripts print difficult to read output #77550

Closed
mjbvz opened this issue Jul 18, 2019 · 8 comments
Closed

test-integration scripts print difficult to read output #77550

mjbvz opened this issue Jul 18, 2019 · 8 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
July 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jul 18, 2019

Issue Type: Bug

Repo

  1. Run ./scripts/test-integration.sh

Bug
See that the output for some sections is printed as:

[ '  \u001b[32m  ✓\u001b[0m\u001b[90m %s\u001b[0m',
  'workspaceFile' ]
[ '  \u001b[32m  ✓\u001b[0m\u001b[90m %s\u001b[0m',
  'workspaceFolders' ]
[ '  \u001b[32m  ✓\u001b[0m\u001b[90m %s\u001b[0m',
  'getWorkspaceFolder' ]
[ '  \u001b[32m  ✓\u001b[0m\u001b[90m %s\u001b[0m',
  'openTextDocument' ]
[ '  \u001b[32m  ✓\u001b[0m\u001b[90m %s\u001b[0m',
  'openTextDocument, illegal path' ]
[ '  \u001b[32m  ✓\u001b[0m\u001b[90m %s\u001b[0m',
  'openTextDocument, untitled is dirty' ]
...

VS Code version: Code - Insiders 1.37.0-insider (112fa76, 2019-07-17T05:34:19.397Z)
OS version: Darwin x64 18.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.02GB free)
Process Argv -psn_0_2667147
Screen Reader no
VM 0%
@mjbvz mjbvz mentioned this issue Jul 20, 2019
Closed
@octref octref added the info-needed Issue requires more information from poster label Jul 25, 2019
@octref
Copy link
Contributor

octref commented Jul 25, 2019

Is this on Azure Devops? It's an issue for Azure Devops's handling of console output. On Travis it looks fine.

@mjbvz
Copy link
Contributor Author

mjbvz commented Jul 25, 2019 •
edited

This also happens on my local machine when you run the tests from the command line

@octref
Copy link
Contributor

octref commented Jul 25, 2019

@Tyriar FYI, any clue why this would be happening?

@Tyriar
Copy link
Member

Tyriar commented Jul 25, 2019

Maybe if mocha was updated? I see it on all platforms.

@Tyriar
Copy link
Member

Tyriar commented Jul 26, 2019

I'm guessing this is related to 4dc7385, I tried to fix it but I haven't used mocha reporters before.

@Tyriar Tyriar assigned joaomoreno and unassigned octref Jul 26, 2019
@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Jul 26, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Jul 29, 2019 •
edited

FYI this is my first time looking at integration tests. @mjbvz @octref @Tyriar For the future, things like these should be forwarded to the Build Master role... which happens to be me this week. Lucky! 👐

@Tyriar 4dc7385 affected unit tests only. And it's a 1 year old change. This broke much more recently.

The fix ended up being related to array spreads, beware of them. 70f5805 cc @bpasero

@joaomoreno joaomoreno added this to the July 2019 milestone Jul 29, 2019
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jul 29, 2019
@joaomoreno
Copy link
Member

Build looks good now: https://dev.azure.com/vscode/VSCode/_build/results?buildId=23873

@Tyriar
Copy link
Member

Tyriar commented Jul 29, 2019

@joaomoreno thanks for looking into this

@jrieken jrieken added the verified Verification succeeded label Jul 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
5 participants
@joaomoreno @jrieken @Tyriar @octref @mjbvz