New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug console stops autoscrolling when a line wraps around #77837
Comments
I can reproduce this, but only if the debug console panel is moved right, not bottom. |
I am also running into this. Possibly related: #70331
Steps to Reproduce:
import numpy as np
x = 5
Does this issue occur when all extensions are disabled?: Yes |
@JoshVarty nice steps. Thanks. I plan to look next week into this. |
I can not reproduce this with node, even though I have multiple lines that wrap. I believe the issue is here I am open for a PR which fixes this. |
I'm away from my desk this week so I can't double check myself, but instead
of using numpy you could try '[i for i in range(20000)]' in the debugger.
That should return a list of 20,000 numbers and I would assume be long
enough to trigger the bug.
…Sent from my iPhone
On Sep 10, 2019, at 9:01 AM, Isidor Nikolic <notifications@github.com> wrote:
I can not reproduce this with node, even though I have multiple lines that
wrap.
Unfortunetly I do not have pyhton setup on my machine to follow the exact
python steps (after doing pip install numpy I get an exception when
debugging the program No module named 'numpy')
I believe the issue is here
<https://github.com/Microsoft/vscode/blob/5a9913099c077fe0c93abcdb88d0cb67169fefcf/src/vs/workbench/contrib/debug/browser/repl.ts#L794>
I am open for a PR which fixes this.
The solution would be to better aproximate the height based on the value
length.
Due to this bad approximation the autoscrolling breaks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77837?email_source=notifications&email_token=AAJQ6P4DGKOFKAREKZDDHX3QI6SCBA5CNFSM4IGKQBP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LF4AQ#issuecomment-529948162>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJQ6P3UJNFZZKXXZZXQ6LDQI6SCBANCNFSM4IGKQBPQ>
.
|
The line doesn't wrap around because the output is trimmed. You might want to try this instead:
Also I can only reproduce with the debug panel on the right (Right click > Move panel right). I can't reproduce the problem with that python line above though. It do with the steps here #79213 (install Python extension, start debug session, move panel to right) |
In trying to come up with a
while in the Debug Console, it outputs
The same is not true for some other non- Based on this, consider the following hypotheses (speculative, but nevertheless):
|
Point 2. makes sense. However this is not only specific to numpy, but to a particular type of output. |
I think it has something to do with Python's I believe Anyways, I've got a numpy-free repro for you:
class Test:
def __repr__(self):
return "\n\t" * 10000
x = Test()
y = "this line is for your breakpoint"
What's interesting is that if you create This only seems to reproduce for me within the context of |
Can you all reproduce this with the debug console panel to the bottom? I can only when it's to the right. Here are my steps to reproduce:
And observe the scrolling problem. This forces me to have the debug console at the bottom while developing an extension. |
@JoshVarty thanks for awesome repro steps. I can repro now, investigating... |
Thanks! 🎉 |
I verified using the nice steps here: #77837 (comment) |
Let's keep this closed since there is already a duplicate which I will look into next milestone. |
Actually my fix just made it worse. Sorry about that. Reverting my fix and reopening this issue. |
@jeanp413 contributed a cool fix for this, thanks a lot! Can people please try this out in vscode insiders from Tuesday and let us know if it is better for you. Thanks a lot! |
Thanks, adding verified label. |
Issue Type: Bug
Notice that when a line that wraps around is printed, autoscrolling stops working and you have to manually scroll to the end to resume it.
VS Code version: Code 1.36.1 (2213894, 2019-07-08T22:56:38.504Z)
OS version: Darwin x64 18.6.0
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: