Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench grid: panel renders according to wrong position #77922

Closed
joaomoreno opened this issue Jul 25, 2019 · 7 comments
Closed

Workbench grid: panel renders according to wrong position #77922

joaomoreno opened this issue Jul 25, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

  1. Disable workbench grid
  2. Place sidebar on the left and panel on the right
  3. Enable workbench grid

Notice:

  • The panel will appear in the bottom
  • The panel will be rendered as if it is on the side: there will be a 1px border on the left side and nothing on the top
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jul 25, 2019
@joaomoreno joaomoreno changed the title Workbench grid: bad migration of panel Workbench grid: bad migration of panel position Jul 25, 2019
@joaomoreno joaomoreno changed the title Workbench grid: bad migration of panel position Workbench grid: panel renders according to wrong position Jul 26, 2019
@joaomoreno
Copy link
Member Author

Easier steps:

  1. Open a New Window
  2. Move panel to the right
  3. Close window
  4. Open a New Window
  5. Toggle show panel

Panel will be on the right but rendered as if its on the bottom.

We gotta remove the legacy sources of truth for view locations.

@sbatten sbatten added this to the July 2019 milestone Jul 29, 2019
@sbatten sbatten added the layout General VS Code workbench layout issues label Jul 29, 2019
@sbatten
Copy link
Member

sbatten commented Jul 29, 2019

@joaomoreno this source of truth should already be fixed and I cannot repro. Can you still in latest?

@sbatten sbatten added the info-needed Issue requires more information from poster label Jul 29, 2019
@microsoft microsoft deleted a comment Jul 29, 2019
@joaomoreno
Copy link
Member Author

joaomoreno commented Jul 29, 2019

The last steps still reproduce both in today's Insiders and Dev.

Notice the bottom class in the div:

image

@joaomoreno
Copy link
Member Author

joaomoreno commented Jul 29, 2019

We should try to remove stuff like this:

And always get them dynamically from the grid.

@sbatten sbatten reopened this Jul 29, 2019
@sbatten
Copy link
Member

sbatten commented Jul 30, 2019

@joaomoreno right now panel position is a workspace specific item while the grid is global, we need to throw out the grids POV if it doesn't work with what's stored. Now I am doing that with the last commit but ideally I'd be able to move the panel and sidebar into the right place before layout. Is that possible?

@joaomoreno
Copy link
Member Author

Ohh I hadn't realised that. Sucks. Well, you have to restore the grid and then run through the Move Panel to the Right action inner workings.

@sbatten
Copy link
Member

sbatten commented Aug 1, 2019

Verification Steps:

  1. Set restoreWindows to none
  2. Follow @joaomoreno steps

@lramos15 lramos15 added verified Verification succeeded and removed info-needed Issue requires more information from poster labels Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants