Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large string values topple the string array settings editor #78235

Closed
kieferrm opened this issue Jul 31, 2019 · 3 comments
Closed

Large string values topple the string array settings editor #78235

kieferrm opened this issue Jul 31, 2019 · 3 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
July 2019

Comments

@kieferrm
Copy link
Member

kieferrm commented Jul 31, 2019 •
edited

While testing #77427

Issue Type: Bug

  1. Start with code-insiders --user-data-dir ./<something new>
  2. Change settings.json to
{
    "terminal.integrated.commandsToSkipShell": [
        "aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa aaaa aaaaa aaaaa aaaaa"
    ]
}
  1. Open the Settings editor
  2. Filter the Settings editor to “commands to skip”

->
image

VS Code version: Code - Insiders 1.37.0-insider (cf03ea3, 2019-07-30T07:10:53.695Z)
OS version: Darwin x64 18.6.0
@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Jul 31, 2019
@octref octref added the settings-editor VS Code settings editor issues label Jul 31, 2019
@octref
Copy link
Contributor

octref commented Jul 31, 2019

@roblourens This is the same issue we have for exclude widget. Do you think we can change the DOM representation to use input (with text-overflow: ellipsis) for displaying the list?

With that we can have something similar to long strings input:

image

@octref octref added this to the August 2019 milestone Jul 31, 2019
@roblourens
Copy link
Member

I would rather see truncated single lines of text than a bunch of input boxes

@octref octref modified the milestones: August 2019, July 2019 Jul 31, 2019
@octref
Copy link
Contributor

octref commented Jul 31, 2019

Here you go, truncated single lines:

image

@octref octref closed this as completed in cc43735 Jul 31, 2019
@rebornix rebornix added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
4 participants
@roblourens @rebornix @octref @kieferrm