Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid root decoration no longer rendered #78510

Closed
isidorn opened this issue Aug 5, 2019 · 1 comment
Closed

Invalid root decoration no longer rendered #78510

isidorn opened this issue Aug 5, 2019 · 1 comment
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
August 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 5, 2019

No description provided.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Aug 5, 2019
@isidorn isidorn added this to the August 2019 milestone Aug 5, 2019
@isidorn isidorn self-assigned this Aug 5, 2019
@isidorn isidorn mentioned this issue Aug 5, 2019
Closed
@isidorn
Copy link
Contributor Author

isidorn commented Aug 21, 2019

Please note that we only show the error decoration on the root once the root gets expanded.
Reason being we do not want to pre-emptevly resolve roots for performance reasons.

verifier: have MR workspace, open the workspace configuration file and put a broken path
Make sure the root shows an error decoration in the explorer once you try to expand it.

fyi @bpasero

@mjbvz mjbvz added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
2 participants
@isidorn @mjbvz