Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseudoterminal.open says events can start firing only after it is called #78705

Closed
Tyriar opened this issue Aug 8, 2019 · 1 comment
Closed

Pseudoterminal.open says events can start firing only after it is called #78705

Tyriar opened this issue Aug 8, 2019 · 1 comment
Assignees
@Tyriar
Labels
api debt Code quality issues terminal Integrated terminal issues
Milestone
August 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 8, 2019

There is a queue mechanism internally before open is called., I think it's more correct to say you cannot access the initial dimensions before it's called.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api terminal Integrated terminal issues labels Aug 8, 2019
@Tyriar Tyriar added this to the August 2019 milestone Aug 8, 2019
@Tyriar Tyriar self-assigned this Aug 8, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 8, 2019

I was wrong, there is a time between when you create it and when you create it and when open called when the events can be fired, but there's no way for an extension to know when that is. I think the queue mechanism can safely be removed now and just install listeners just before open is triggered.

@Tyriar Tyriar added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Aug 8, 2019
@Tyriar Tyriar closed this as completed in 3dc832d Aug 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
1 participant
@Tyriar