Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breaker: common/webview.ts references HTMLElement #79424

Closed
bpasero opened this issue Aug 19, 2019 · 0 comments
Closed

Layer breaker: common/webview.ts references HTMLElement #79424

bpasero opened this issue Aug 19, 2019 · 0 comments
Assignees
@mjbvz
Labels
debt Code quality issues
Milestone
August 2019

Comments

@bpasero
Copy link
Member

bpasero commented Aug 19, 2019

It should move into browser.

vscode/src/vs/workbench/contrib/webview/common/webview.ts

Line 93 in 4fa0890

readonly container: HTMLElement;

@bpasero bpasero added the debt Code quality issues label Aug 19, 2019
@bpasero bpasero mentioned this issue Aug 19, 2019
Closed
@mjbvz mjbvz added this to the August 2019 milestone Aug 19, 2019
@mjbvz mjbvz closed this as completed in df0dd2e Aug 20, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
2 participants
@bpasero @mjbvz