New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-browser/openerService.ts isn't needed #79453
Comments
Oh, |
@jrieken to be clear: instead of having a separate service, we allow to register an opener that takes care of the |
Yeah, well actually two issues
|
@jrieken yeah I can see to get the count to 2. We can think about merging |
Commit ba69d8d adds another opener service so that it can take a dependency onto the
IWindowService
. That's not needed as the base opener service allows to register handler, see:vscode/src/vs/platform/opener/common/opener.ts
Line 23 in c8d44e2
Yet another opener service adds unnecessary code/bloat
The text was updated successfully, but these errors were encountered: