Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad layout when using native title bar on Windows #79475

Closed
Tyriar opened this issue Aug 19, 2019 · 14 comments
Closed

Bad layout when using native title bar on Windows #79475

Tyriar opened this issue Aug 19, 2019 · 14 comments
Assignees
@alexdima @sbatten
Labels
important Issue identified as high-priority
Milestone
August 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2019

image

VS Code version: Code - Insiders 1.38.0-insider (c8d44e2, 2019-08-19T12:53:53.607Z)
OS version: Windows_NT x64 10.0.18956
Remote OS version: Linux x64 4.15.0-55-generic

System Info
Item Value
CPUs Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (8 x 3492)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: unavailable_off
protected_video_decode: unavailable_off
rasterization: unavailable_off
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 63.92GB (44.07GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote SSH: ubuntu
OS Linux x64 4.15.0-55-generic
CPUs Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (4 x 3491)
Memory (System) 10.79GB (0.86GB free)
VM 0%
Extensions (14)
Extension Author (truncated) Version
vscode-svgviewer css 2.0.0
EditorConfig Edi 0.13.0
vscode-pull-request-github-insiders Git 2019.8.19623
vscode-docker ms- 0.7.0
remote-containers ms- 0.67.4
remote-ssh-edit-nightly ms- 2019.8.26820
remote-ssh-explorer-nightly ms- 2019.8.26820
remote-ssh-nightly ms- 2019.8.26820
remote-wsl ms- 0.39.3
vscode-typescript-tslint-plugin ms- 1.2.2
debugger-for-chrome msj 4.11.7
material-icon-theme PKi 3.8.1
vscode-terminal-api-example vsc 0.0.1
vscode-todo-highlight way 1.0.4

(2 theme extensions excluded)
@Tyriar
Copy link
Member Author

Tyriar commented Aug 20, 2019 •
edited

Happened again, this was in a workspace I haven't opened in a while:

image

Version: 1.38.0-insider (user setup)
Commit: c8d44e2
Date: 2019-08-19T12:53:53.607Z
Electron: 4.2.9
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18956

Resizing the window didn't fix it completely, the panel and sidebar are visible but nothing is active:

image

@sbatten
Copy link
Member

sbatten commented Aug 21, 2019

I've tried using the native titlebar with a bunch of my old workspaces and haven't been able to repro, yet. I'm hoping someone else can repro this.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2019

Just happened again when I opened the first new window of the morning. Successive new windows don't show the problem though.

@sbatten
Copy link
Member

sbatten commented Aug 21, 2019

/duplicate #79580

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 21, 2019
@vscodebot
Copy link

vscodebot bot commented Aug 21, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Aug 21, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2019

@sbatten while related, it might be a different issue? The status bar was affected for #79580 but not this

@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2019

In console:

ERR Cannot read property 'toString' of undefined: TypeError: Cannot read property 'toString' of undefined
    at Object.t.asCSSUrl (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:266:660)
    at new k (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5252:198)
    at d._createInstance (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1476:255)
    at d.createInstance (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1475:676)
    at e.getCompositeActions (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5272:96)
    at Object.getActivityAction (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5267:767)
    at Object.get activityAction [as activityAction] (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5264:607)
    at e.forEach (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5262:54)
    at Array.forEach (<anonymous>)
    at S.updateCompositeSwitcher (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5261:760)
    at S.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5258:111)
    at e.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5274:454)
    at v.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:489:535)
    at m.layoutView (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:462:813)
    at m.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:463:66)
    at viewItems.forEach.e (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:814)
    at Array.forEach (<anonymous>)
    at b.layoutViews (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:801)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:921)
    at f.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:482:685)
    at p.layoutView (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:462:813)
    at p.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:462:981)
    at viewItems.forEach.e (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:814)
    at Array.forEach (<anonymous>)
    at b.layoutViews (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:801)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:921)
    at f.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:482:685)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:491:106)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:499:88)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:504:895)
    at W.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5393:265)
    at W.<anonymous> (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5403:437)
    at Generator.next (<anonymous>)
    at file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:566
    at new Promise (<anonymous>)
    at n (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:343)
    at e.invokeFunction.t (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5403:79)
    at d.invokeFunction (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1475:444)
    at W.startup (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5403:61)
    at Q.<anonymous> (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5931:430)
    at Generator.next (<anonymous>)
    at r (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:399)

@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2019

image

@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2019

asDomUri returning undefined:

vscode/src/vs/base/browser/dom.ts

Lines 1191 to 1199 in 6e43f06

export function asDomUri(uri: URI): URI {
if (!uri) {
return uri;
}
if (Schemas.vscodeRemote === uri.scheme) {
return RemoteAuthorities.rewrite(uri.authority, uri.path);
}
return uri;
}

@sbatten
Copy link
Member

sbatten commented Aug 21, 2019

@alexandrudima looks like this could be caused by 623855b

@sbatten sbatten removed the *duplicate Issue identified as a duplicate of another issue(s) label Aug 21, 2019
@sbatten sbatten reopened this Aug 21, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2019

I'm guessing this is the problem?

vscode/src/vs/base/browser/dom.ts

Lines 1191 to 1194 in 026b470

export function asDomUri(uri: URI): URI {
if (!uri) {
return uri;
}

Shouldn't strict null checks cover that case 🤔

@roblourens
Copy link
Member

Not just windows, also got it on Mac, every window is totally broken.

@roblourens roblourens added the important Issue identified as high-priority label Aug 21, 2019
@EbXpJ6bp EbXpJ6bp mentioned this issue Aug 21, 2019
Closed
@alexdima alexdima added this to the August 2019 milestone Aug 22, 2019
@alexdima
Copy link
Member

I could not reproduce, but I pushed code to protect asCSSUrl from bad callers with type confusion...

@alexdima
Copy link
Member

@Tyriar What version were you using? You can deminify stacks using https://github.com/alexandrudima/vscode-stack-beautifier

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

@sbatten sbatten

Labels
important Issue identified as high-priority
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @alexdima @sbatten