Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM: repository view order is upside down #79519

Closed
bpasero opened this issue Aug 20, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Closed

SCM: repository view order is upside down #79519

bpasero opened this issue Aug 20, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Milestone
November 2019

Comments

@bpasero
Copy link
Member

bpasero commented Aug 20, 2019

See:

image
@sandy081 sandy081 removed their assignment Aug 26, 2019
@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Aug 30, 2019
@joaomoreno
Copy link
Member

@sandy081 This is a problem with the views model:

vscode/src/vs/workbench/browser/parts/views/views.ts

Line 385 in b3f85bc

return (this.getViewOrder(a) - this.getViewOrder(b)) || this.getGroupOrderResult(a, b) || (a.id < b.id ? -1 : 1);

I can't do anything since if I provide an order, it will eventually override whatever the user changed manually. So I can't provide an order, so the views get sorted by id. Why are they sorted by id anyway? If they don't have an order they should stay in the order they got registered.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Sep 2, 2019
@sandy081 sandy081 added this to the September 2019 milestone Sep 2, 2019
@sandy081
Copy link
Member

sandy081 commented Sep 2, 2019

Makes sense.

sandy081 added a commit that referenced this issue Sep 2, 2019
@sandy081
revert fix ##79519
f84c7c7
sandy081 added a commit that referenced this issue Sep 2, 2019
@sandy081
Fix #79519
f061114
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@bpasero bpasero added the verified Verification succeeded label Oct 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 17, 2019
sandy081 added a commit that referenced this issue Nov 18, 2019
@sandy081
Revert "Fix #79519"
adb4aae 
This reverts commit f061114.
@sandy081 sandy081 removed the verified Verification succeeded label Nov 18, 2019
@sandy081
Copy link
Member

Reopening this as the fix causes views to be created twice.

@sandy081 sandy081 reopened this Nov 18, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Milestone
November 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
4 participants
@joaomoreno @bpasero @RMacfarlane @sandy081