Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree element not found error when creating nested folders in single root workspace #79540

Closed
jeanp413 opened this issue Aug 21, 2019 · 2 comments · Fixed by #79542
Closed

Tree element not found error when creating nested folders in single root workspace #79540

jeanp413 opened this issue Aug 21, 2019 · 2 comments · Fixed by #79542
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
August 2019

Comments

@jeanp413
Copy link
Contributor

From #78153 (comment)

Steps to Reproduce:

  1. Open single folder in vscode containing just one folder FolderA
  2. Select FolderA, create child folder f
  3. Click New Folder Action and cancel
  4. Click New Folder Action again, type a/s/d and accept
  5. Click New Folder Action and cancel
  6. Click New Folder Action again, type q/w/e and accept

bugtreeexpandsinglefolder
@vscodebot
Copy link

vscodebot bot commented Aug 21, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

jeanp413 added a commit to jeanp413/vscode that referenced this issue Aug 21, 2019
@jeanp413
Don't auto expand if it's root in indexTreeModel. Fixes microsoft#79540
2ebaa78
This was referenced Aug 21, 2019
Merged
Merged
@RMacfarlane RMacfarlane added the file-explorer Explorer widget issues label Aug 21, 2019
@isidorn isidorn added this to the August 2019 milestone Aug 21, 2019
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Aug 21, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 21, 2019

Great catch and a wonderful fix, thanks a lot!

@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Don't auto expand if it's root in indexTreeModel jeanp413/vscode
3 participants
@isidorn @RMacfarlane @jeanp413