Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Language Server fails if client doesn't set dataPaths in InitializationOptions #79599

Closed
mickaelistria opened this issue Aug 21, 2019 · 3 comments
Closed

CSS Language Server fails if client doesn't set dataPaths in InitializationOptions #79599

mickaelistria opened this issue Aug 21, 2019 · 3 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone
August 2019

Comments

@mickaelistria
Copy link
Contributor

mickaelistria commented Aug 21, 2019 •
edited

  • VSCode Version: 1.37.1
  • OS Version: Fedora 30

I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE).
I noticed that if I start the CSS-LS without passing a dataPaths element to initialization, the LS will fail because of TypeError: Cannot read property 'map' of undefined.
One of the important lines in the stack trace is https://github.com/microsoft/vscode/blob/master/extensions/css-language-features/server/src/cssServerMain.ts#L107 .
@mickaelistria
Copy link
Contributor Author

Submitted PR #79600 for this issue.

@RMacfarlane RMacfarlane added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Aug 21, 2019
mickaelistria added a commit to mickaelistria/vscode that referenced this issue Aug 21, 2019
@mickaelistria
Issue microsoft#79599 - CSS LS fails if InitializationOptions.dataPat…
558d23b 
…hs not set

Signed-off-by: Mickael Istria <mistria@redhat.com>
octref added a commit that referenced this issue Aug 21, 2019
@octref
Merge pull request #79600 from mickaelistria/issue-79599
2c4790d 
Issue #79599 - CSS LS fails if InitializationOptions.dataPaths not set
@octref
Copy link
Contributor

octref commented Aug 21, 2019

Fixed by #79600.

@octref octref closed this as completed Aug 21, 2019
@octref octref added this to the August 2019 milestone Aug 21, 2019
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Aug 21, 2019
@mjbvz mjbvz added the verified Verification succeeded label Aug 28, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Aug 28, 2019

Verified in master by removing the dataPaths initializationOptions

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
4 participants
@mickaelistria @RMacfarlane @octref @mjbvz