Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double click on a reference will not open target window editor #79633

Closed
jonlepage opened this issue Aug 22, 2019 · 12 comments · Fixed by microsoft/azuredatastudio#7206
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jonlepage
Copy link

hi, if you select a method, right click and select search reference.
Then if you double click in a reference, if the ref are in other window editor, the editor not open scaling.
Can we fix this bug plz :)
image

@sbatten
Copy link
Member

sbatten commented Aug 23, 2019

@djmisterjon can you check your setting workbench.useExperimentalGridLayout

@jonlepage
Copy link
Author

it activated but what this should do ?

@sbatten
Copy link
Member

sbatten commented Aug 24, 2019

@djmisterjon It seems that setting does not make a difference for me anyway. I see the collapsed editor group is not expanded when focused this way. Additionally, I see that there is some extra whitespace at the bottom of the image, is that happening in your window?

@sbatten sbatten assigned bpasero and unassigned sbatten Aug 24, 2019
@jonlepage
Copy link
Author

jonlepage commented Aug 24, 2019

yes it focus on the correct line with highlight, but i want auto expanded the window.
And yes you true, it work in debug Mode with breakpoint, when travel in breakpoint it auto open and expanded window needed.
But in this ways, it not work, maybe a dev forget add the feature ?
The extra white space it the microsoft snapScreen editor, no related to vscode or window environment.

@bpasero bpasero modified the milestones: September 2019, August 2019 Aug 24, 2019
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 24, 2019
@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

I think the issue is as follows:

  • there is an editor group minimized that is not active
  • clicking on the reference will prefer to reveal the editor from the group instead of opening it in the current group
  • we preserve focus in the reference view because the interaction is by mouse and as such we do not activate the minimized group
  • as such the group does not maximize

I pushed a change so that a minimized editor group will maximize even if not getting activated.

@jonlepage
Copy link
Author

jonlepage commented Aug 26, 2019

@bpasero yes, sorry, some difficult to explain my brain in english,it why i made screen, but yes you say all.
thank you for the fast fix man.

@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

@djmisterjon no worries. I am actually thinking that maybe a better fix would be to not just restore the minimized group but also set it active. It feels weird to me that you click on an item and you are not getting any feedback if the item is already opened in some group. At the very minimum I think it should not only restore (if minimized) but also activate the group. Would you agree?

@jonlepage
Copy link
Author

@djmisterjon yes +1 for active group 👍

@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

OK, pushed that via #79798

@mjbvz mjbvz added verified Verification succeeded and removed verified Verification succeeded labels Aug 28, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Aug 28, 2019

Tested on eeab6fc with "workbench.editor.revealIfOpen": true but it still seems that clicking on the file will not activate or expand the editor in the minimized group

@mjbvz mjbvz reopened this Aug 28, 2019
@mjbvz mjbvz added the verification-found Issue verification failed label Aug 28, 2019
@bpasero bpasero removed the verification-found Issue verification failed label Aug 29, 2019
@bpasero
Copy link
Member

bpasero commented Aug 29, 2019

@mjbvz good catch, this was obviously broken when I made all extensions go back to the previous solution and the "Find References" view is an extension.

I added another value to the EditorActivation option: RESTORE and now all extensions (including your webview stuff) will use that option. This option will NOT activate the group (so we preserve todays behavior), but will restore a group IF it is minimized.

@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2019
@jonlepage
Copy link
Author

test in version 1.38.0 and it just work fine.
Thanks you so much dude , am so happy now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants