Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky or broken test? #79692

Closed
jrieken opened this issue Aug 23, 2019 · 1 comment · Fixed by #115775
Closed

Flaky or broken test? #79692

jrieken opened this issue Aug 23, 2019 · 1 comment · Fixed by #115775
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues unit-test-failure verified Verification succeeded
Milestone
February 2021

Comments

@jrieken
Copy link
Member

jrieken commented Aug 23, 2019

TerminalConfigHelper - getFont fontFamily failed in https://dev.azure.com/vscode/VSCode/_build/results?buildId=25682. I have pushed a commit to comment out this test
jrieken added a commit that referenced this issue Aug 23, 2019
@jrieken
disable failing test, #79692
46993bc
@Tyriar Tyriar added this to the October 2019 milestone Sep 6, 2019
@Tyriar Tyriar added the terminal Integrated terminal issues label Sep 6, 2019
@Tyriar Tyriar modified the milestones: October 2019, Backlog Oct 29, 2019
@joaomoreno
Copy link
Member

@Tyriar Let's fix this or close it if already fixed.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 22, 2020
@joaomoreno joaomoreno modified the milestones: Backlog, January 2021 Jan 7, 2021
@Tyriar Tyriar modified the milestones: January 2021, February 2021 Jan 25, 2021
meganrogge added a commit that referenced this issue Feb 4, 2021
@meganrogge
fix #79692
7c52de3
@meganrogge meganrogge mentioned this issue Feb 4, 2021
Closed
meganrogge added a commit that referenced this issue Feb 4, 2021
@meganrogge
fix #79692, re-enable test
5e27d39
@meganrogge meganrogge mentioned this issue Feb 4, 2021
Merged
@jrieken jrieken added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues unit-test-failure verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

Successfully merging a pull request may close this issue.

Re-enable terminal fontFamily unit test microsoft/vscode
5 participants
@joaomoreno @bpasero @jrieken @Tyriar and others