Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly provide deprecated CompletionItem #79964

Closed
octref opened this issue Aug 28, 2019 · 0 comments
Closed

Properly provide deprecated CompletionItem #79964

octref opened this issue Aug 28, 2019 · 0 comments
Assignees
@octref
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling debt Code quality issues
Milestone
October 2019

Comments

@octref
Copy link
Contributor

octref commented Aug 28, 2019

We are doing #79584 to dogfood the experimental API. The change involved microsoft/vscode-css-languageservice#174 and #79962.

Once #23927 is finalized and LSP library adopted it, we should remove the changes introduced in both PRs to do this cleanly through LSP.

@aeschli fyi
@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling debt Code quality issues labels Aug 28, 2019
@octref octref added this to the October 2019 milestone Aug 28, 2019
@octref octref self-assigned this Aug 28, 2019
octref added a commit that referenced this issue Oct 22, 2019
@octref
Part of #79964
7fa28ec
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling debt Code quality issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
1 participant
@octref