Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoadedScriptsView: id of item should not depend on label #80379

Closed
isidorn opened this issue Sep 5, 2019 · 2 comments
Closed

LoadedScriptsView: id of item should not depend on label #80379

isidorn opened this issue Sep 5, 2019 · 2 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
October 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 5, 2019

When a session's name get changed the Loaded Scripts View looses selection / expansion state for that session.
The reason for this is that we compute the tree id of the session element based on the label here

We should not use the label when computing ids, but we should use some internal id instead (or the id of the underlying DebugSession element in this case)

fyi @dgozman
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 5, 2019
@isidorn isidorn mentioned this issue Sep 5, 2019
Merged
@isidorn
Copy link
Contributor Author

isidorn commented Sep 5, 2019

Also on session change name we shuold not do all this magic here
I think a simple tree.rerender should be enough (on top when we change the ID computation to no longer depend on label)

@weinand weinand added this to the October 2019 milestone Oct 16, 2019
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Oct 16, 2019
@weinand
Copy link
Contributor

weinand commented Oct 23, 2019

The ID of session nodes is now based on the session ID instead of the session label.

@roblourens roblourens added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@roblourens @weinand @isidorn