Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM placeholder is soo long that input widget wraps #80386

Closed
jrieken opened this issue Sep 5, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Closed

SCM placeholder is soo long that input widget wraps #80386

jrieken opened this issue Sep 5, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@joaomoreno @bpasero @jrieken
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@jrieken
Copy link
Member

jrieken commented Sep 5, 2019

I would not expect that the input box wrap when it shows a placeholder, only when I type something

Screenshot 2019-09-05 at 12 24 26
@joaomoreno
Copy link
Member

joaomoreno commented Sep 5, 2019 •
edited

#79029

OK you guys discuss, let me know who wins. I'm more in favor of leaving it as is.

@bpasero bpasero added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 5, 2019
@bpasero
Copy link
Member

bpasero commented Sep 5, 2019

I don't mind that we do not wrap, however this:

image

Looks broken. If we do not wrap then we should really not wrap and show 1 line with "..." in that input field.

@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@bpasero bpasero

@jrieken jrieken

Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
3 participants
@joaomoreno @bpasero @jrieken