Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow extension webviews to have proper tooltip in Explorer #81286

Closed
cfehse opened this issue Sep 22, 2019 · 4 comments
Closed

[Feature] Allow extension webviews to have proper tooltip in Explorer #81286

cfehse opened this issue Sep 22, 2019 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone
October 2019

Comments

@cfehse
Copy link

cfehse commented Sep 22, 2019

Description
It would be nice if extension webviews could have a human readable tooltip in the explorer. Not something like "\webview-panel\webview...". I found nothing in the extension API to set the explorer tooltip. The webview-sample (https://github.com/microsoft/vscode-extension-samples/tree/master/webview-sample) shows this generic tooltip as well.

  • VSCode Version: 1.38.1
  • OS Version: Windows 10

Webview-tooltip
@kieferrm kieferrm added the api label Sep 23, 2019
@mjbvz mjbvz added the webview Webview issues label Sep 23, 2019
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed api labels Sep 30, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Sep 30, 2019

@isidorn After reviewing the code, I think this may be a bug with the open editors view. We show the expected title if you hover over the webview's editor tab but show the resource path when you hover over the title in the open editors view:

Sep-30-2019 10-47-14

@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2019

I can look into this next milestone, we were always behaving like this thus not a regression. October.
open editors view is not aware of the type of the editor, thus the editor input description might be more precise than the open editors one. Not if we can improve this, though will give you more details next week.

@isidorn isidorn added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Oct 1, 2019
@isidorn isidorn added this to the October 2019 milestone Oct 1, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 22, 2019

Thanks for filling this.
Please try it out with Wednesday VSCode insiders and let me know if the issue is fixed for you.
I tried it out and now it works great for me.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 22, 2019
@cfehse
Copy link
Author

cfehse commented Oct 23, 2019

@isidorn

Yes works like a charm with the insiders build.

Thank you!

@isidorn isidorn added the verified Verification succeeded label Oct 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@isidorn @kieferrm @mjbvz @cfehse