Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When two editors are contributed for the same file, neither gets chosen #81828

Closed
alexr00 opened this issue Oct 2, 2019 · 1 comment
Closed

When two editors are contributed for the same file, neither gets chosen #81828

alexr00 opened this issue Oct 2, 2019 · 1 comment
Assignees
@mjbvz
Labels
custom-editors Custom editor API (webview based editors) verified Verification succeeded webview Webview issues
Milestone
February 2020

Comments

@alexr00
Copy link
Member

alexr00 commented Oct 2, 2019 •
edited

Testing #81698

This happens even if I make one of them "discretion": "default"

This first time I opened a .png with two editors to handle png installed, I was shown an editor that had a message about the file being binary.
I opened the file as binary.
Then I ran the reopen command to open with one of my image editors. That worked and activated the editor extension.
After that, when opening pngs they opened as binary then asked me to pick which editor to use.

This seems like an awkward flow.

  • I shouldn't have gotten the binary message, just immediately show me the quick pick with editor options.
  • Later, I don't think the file should open as binary first then offer the quick pick. Only show the quick pick, and offer to make one of the editors default.
@mjbvz mjbvz added this to the October 2019 milestone Oct 2, 2019
@mjbvz mjbvz added the webview Webview issues label Oct 19, 2019
@mjbvz mjbvz modified the milestones: October 2019, November 2019 Oct 31, 2019
@mjbvz mjbvz modified the milestones: November 2019, December 2019 Dec 3, 2019
@mjbvz mjbvz added the custom-editors Custom editor API (webview based editors) label Jan 27, 2020
@mjbvz mjbvz modified the milestones: January 2020, February 2020 Jan 27, 2020
@mjbvz mjbvz closed this as completed in 706ba66 Feb 19, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 19, 2020

Ok, so the clarify the expected behavior now: if there are 2+ editors and we can't pick one to show, we still show the default editor plus the quick pick. I found it confusing if we only show the quick pick in such cases as it looks like the file open did nothing.

Based on your feedback, I've added a button in the quick pick that will set the selected editor as the default. This currently is drawn using a setting gear but we can discuss this further in one of the UX syncs.

If others feel strongly about not showing the default editor on first open, we can also revisit that decision

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Feb 19, 2020
@connor4312 connor4312 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Feb 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
custom-editors Custom editor API (webview based editors) verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@connor4312 @mjbvz @alexr00