Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New setting debug.onTaskErrors values are missing descriptions #81868

Closed
gregvanl opened this issue Oct 2, 2019 · 6 comments
Closed

New setting debug.onTaskErrors values are missing descriptions #81868

gregvanl opened this issue Oct 2, 2019 · 6 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
September 2019

Comments

@gregvanl
Copy link

gregvanl commented Oct 2, 2019

debug.onTaskErrors has values: "debugAnyway", "prompt", and "showErrors".

There are no descriptions for the three possible values so nothing is displayed in the Settings editor enum dropdown nor IntelliSense in the JSON editor.
@weinand weinand assigned isidorn and unassigned weinand Oct 3, 2019
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 3, 2019
@weinand weinand added this to the September 2019 milestone Oct 3, 2019
@isidorn isidorn closed this as completed in 3b5e571 Oct 3, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 3, 2019

@gregvanl Great catch. Adding bug label so we verify this.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Oct 3, 2019
@miguelsolorio miguelsolorio added the verified Verification succeeded label Oct 3, 2019
@miguelsolorio
Copy link
Contributor

Verified that the description shows up, but should the description be unique to each value? That's how our other settings work.

image

image

@miguelsolorio
Copy link
Contributor

Actually, re-opening as it appears the commit has a description for each value but only one is ever shown:

image

image

@miguelsolorio miguelsolorio reopened this Oct 3, 2019
@miguelsolorio miguelsolorio added verification-found Issue verification failed and removed verified Verification succeeded labels Oct 3, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 3, 2019 •
edited

@misolori the description is only shown in the Settings UX, not in JSON. Please verify it in the settings UX :)
The json inteli-sense always shows the description of the whole setting, not of the value.

@isidorn isidorn closed this as completed Oct 3, 2019
@isidorn isidorn removed the verification-found Issue verification failed label Oct 3, 2019
@miguelsolorio
Copy link
Contributor

@isidorn never mind, I'm an idiot and didn't realize this isn't on Insiders yet. Verified out of master that this is fixed in both:

image

image

@miguelsolorio miguelsolorio added the verified Verification succeeded label Oct 3, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 4, 2019

Oh I was not aware that we even show it in settings json - sweet.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

No branches or pull requests
4 participants
@weinand @isidorn @gregvanl @miguelsolorio