Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screencast mode does not work with webviews #82113

Closed
DonJayamanne opened this issue Oct 8, 2019 · 0 comments · Fixed by #83111
Closed

Screencast mode does not work with webviews #82113

DonJayamanne opened this issue Oct 8, 2019 · 0 comments · Fixed by #83111
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone
October 2019

Comments

@DonJayamanne
Copy link
Contributor

  • Version: 1.39.0-insider
  • Commit: c8252b6
  • Date: 2019-10-04T09:23:20.797Z
  • Electron: 4.2.10
  • Chrome: 69.0.3497.128
  • Node.js: 10.11.0
  • V8: 6.9.427.31-electron.0
  • OS: Darwin x64 18.7.0

Steps to Reproduce:

  1. Open VS Code Insiders
  2. Toggle screencast mode
  3. Open a textfile and confirm screencast mode works
  4. Open a webview panel (custom extension code) and screen cast does not work for keyboard or mouse event in the webview

Does this issue occur when all extensions are disabled?: N/A (this is specific to all extensions with webviews).
@mjbvz mjbvz self-assigned this Oct 8, 2019
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues help wanted Issues identified as good community contribution opportunities labels Oct 16, 2019
@mjbvz mjbvz added this to the October 2019 milestone Oct 22, 2019
@mjbvz mjbvz removed the help wanted Issues identified as good community contribution opportunities label Oct 22, 2019
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 22, 2019
@mjbvz
Fix screencast mode for webviews
d962881 
Fixes microsoft#82113

Webviews always dispatch emulated keyboard events to the window. This causes them to bypass screencast mode's `keydown` handler

This change makes screencast mode instead listen for events on the window element
@mjbvz mjbvz mentioned this issue Oct 22, 2019
Merged
@JacksonKearl JacksonKearl added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
October 2019
Development

Successfully merging a pull request may close this issue.

Fix screencast mode for webviews mjbvz/vscode
3 participants
@DonJayamanne @JacksonKearl @mjbvz