Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot enable themes #82610

Closed
CloudSecuritySmith opened this issue Oct 15, 2019 · 7 comments
Closed

Cannot enable themes #82610

CloudSecuritySmith opened this issue Oct 15, 2019 · 7 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues verified Verification succeeded
Milestone
November 2019

Comments

@CloudSecuritySmith
Copy link

Issue Type: Bug

Get a "Cannot read property 'id' of undefined" error when trying to enable any theme.

Have tried uninstall (including clearing theme and settings files from disk) and restart several times. Only get error once I try to enable a theme.

Installing other extensions appears to work as expected but any theme, on a fresh install, results in the error.

VS Code version: Code 1.39.1 (88f15d1, 2019-10-10T23:31:28.683Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2712)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.88GB (25.30GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (1)
Extension Author (truncated) Version
python ms- 2019.10.41019

(1 theme extensions excluded)
@roblourens
Copy link
Member

Do you see a full stack trace in the developer tools? (Help > Toggle developer tools)

@roblourens roblourens added the info-needed Issue requires more information from poster label Oct 15, 2019
@CloudSecuritySmith
Copy link
Author

notificationsAlerts.ts:38 TypeError: Cannot read property 'id' of undefined at o.some.e (extensionsActions.ts:1305) at Array.some (<anonymous>) at e.run (extensionsActions.ts:1305) at t.ActionRunner.runAction (actions.ts:216) at t.ActionRunner.run (actions.ts:208) at p.onClick (actionbar.ts:168) at Immediate.options.options.isMenu.i.setImmediate (actionbar.ts:138) at runCallback (timers.js:694) at tryOnImmediate (timers.js:665) at processImmediate (timers.js:647)

Above is the output from the developer tools. This is after a fresh install with previous extensions and settings removed. Get same error regardless of the theme I try to install.

@AJStacy
Copy link

AJStacy commented Oct 19, 2019

I too am experiencing this.

@vscodebot vscodebot bot removed the new release label Oct 20, 2019
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues and removed info-needed Issue requires more information from poster labels Nov 15, 2019
@sandy081 sandy081 added this to the November 2019 milestone Nov 15, 2019
@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 18, 2019
Closed
@rustiphyde
Copy link

Me as well...it keeps reverting back to "Default Dark+" even when I delete the settings.json file and replace it with a brand new one that I code myself to have the color theme be anything other than "Default Dark+" it still changes the content of that settings.json file to have the theme be "Default Dark+". Somewhere someone must have broke the code during the last update.

@rustiphyde
Copy link

Why do people keep closing these issues when it obviously isn't resolved?

@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 21, 2019
Closed
@gjsjohnmurray
Copy link
Contributor

Why do people keep closing these issues when it obviously isn't resolved?

This one hasn't been closed. Others that are duplicates have been as part of issue management procedures.

@egamma egamma mentioned this issue Nov 25, 2019
Closed
@sandy081
Copy link
Member

Steps to repro:

  • Open Settings and set theme to a random value that does not exist
    "workbench.colorTheme": "abcd"
  • Open Extension Viewlet and make sure you have any theme extension installed
  • Click on the gear icon of the theme extension and Select Set Color Theme action
    🐛 "Cannot read property 'id' of undefined" error appears

devrsi0n pushed a commit to devrsi0n/vscode that referenced this issue Nov 27, 2019
@sandy081
fix microsoft#82610
166f4c9
@mjbvz mjbvz added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
7 participants
@roblourens @AJStacy @gjsjohnmurray @sandy081 @mjbvz @rustiphyde @CloudSecuritySmith