Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace URL handler #82869

Closed
sguillia opened this issue Oct 18, 2019 · 7 comments
Closed

Marketplace URL handler #82869

sguillia opened this issue Oct 18, 2019 · 7 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-os-integration Native OS integration issues
Milestone
October 2019

Comments

@sguillia
Copy link

These URLs trigger the vscode default URL handlers.

vscode:extension/ms-vscode.csharp
vscode-insiders:extension/ms-vscode.csharp

They work great when VS Code is already open: the extension ms-vscode.csharp opens up in the marketplace.

When no instance of VS Code is running, VS Code opens, but the marketplace doesn't show up.

Fixing this would allow an Open in marketplace button.

VS Code version: Code - Insiders 1.40.0-insider (3f6ed25, 2019-10-15T05:26:04.723Z)
OS version: Linux x64 4.15.0-65-generic
@SupinePandora43
Copy link

also: when vscode trying to open url with extension page on marketplace, it opens browser!

@joaomoreno
Copy link
Member

Why does this keep breaking.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-os-integration Native OS integration issues labels Oct 21, 2019
@joaomoreno joaomoreno added this to the October 2019 milestone Oct 21, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Oct 21, 2019 •
edited

Very likely the same underlying problem as #73101

cc @bpasero

@joaomoreno
Copy link
Member

Actually, no... the fix for #73101 caused this issue!

@SupinePandora43
Copy link

@joaomoreno, can i make issue for #82869 (comment) ?

@joaomoreno
Copy link
Member

also: when vscode trying to open url with extension page on marketplace, it opens browser!

What are the steps to reproduce?

@SupinePandora43
Copy link

@joaomoreno , write in some file vscode marketplace extension url, and open it (CTRL+Click)

@joaomoreno joaomoreno mentioned this issue Oct 24, 2019
Closed
@roblourens roblourens added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-os-integration Native OS integration issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @sguillia @SupinePandora43