Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize env.asExternalUri #82896

Closed
mjbvz opened this issue Oct 19, 2019 · 1 comment
Closed

Finalize env.asExternalUri #82896

mjbvz opened this issue Oct 19, 2019 · 1 comment
Assignees
@mjbvz
Labels
api api-finalization on-testplan
Milestone
October 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 19, 2019

Tracks finalization of the proposed env.asExternalUri function
@mjbvz mjbvz added this to the October 2019 milestone Oct 19, 2019
@mjbvz mjbvz self-assigned this Oct 19, 2019
@mjbvz
Copy link
Contributor Author

mjbvz commented Oct 19, 2019 •
edited

For #76259, we may need a way to force a uri to be resolved as if it were remote. I think we can add this as an option to the api even after it has been finalized:

declare function asExternalUri(uri: Uri, options?: { forceResolveFromWorkspace?: boolean })

@mjbvz mjbvz closed this as completed in 06def35 Oct 21, 2019
@mjbvz mjbvz mentioned this issue Oct 29, 2019
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api api-finalization on-testplan
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
1 participant
@mjbvz