Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste shortcut not working anymore #83002

Closed
PierreMarchand20 opened this issue Oct 21, 2019 · 5 comments
Closed

Paste shortcut not working anymore #83002

PierreMarchand20 opened this issue Oct 21, 2019 · 5 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues terminal Integrated terminal issues verified Verification succeeded
Milestone
October 2019

Comments

@PierreMarchand20
Copy link

PierreMarchand20 commented Oct 21, 2019 •
edited

  • Version: 1.39.2
  • Commit: 6ab5985
  • Date: 2019-10-15T15:33:00.827Z
  • Electron: 4.2.10
  • Chrome: 69.0.3497.128
  • Node.js: 10.11.0
  • V8: 6.9.427.31-electron.0
  • OS: Darwin x64 18.7.0

it seems to me that we could copy/paste in the terminal using the usual shortcut. But it seems that the shortcut for paste does not exist anymore:

image

It is a little bit strange since all the other usual shortcuts are defined.
@vscodebot
Copy link

vscodebot bot commented Oct 21, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@PierreMarchand20
Copy link
Author

Even in the editor actually it disappeared
image
and this with all extensions disabled and after reloading the window

@PierreMarchand20 PierreMarchand20 changed the title Paste in terminal Paste shortcut not working anymore Oct 21, 2019
@AndiDog AndiDog mentioned this issue Oct 22, 2019
Closed
@Tyriar Tyriar assigned sbatten and unassigned Tyriar Oct 22, 2019
@sbatten
Copy link
Member

sbatten commented Oct 22, 2019

I can reproduce in stable and insiders in the terminal. @PierreMarchand20 I cannot reproduce inside the editor.

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues menus Menu items and widget issues labels Oct 22, 2019
@sbatten
Copy link
Member

sbatten commented Oct 22, 2019

@Tyriar seems intentional?

vscode/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

Lines 362 to 366 in 877ce7a

actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(TerminalPasteAction, TerminalPasteAction.ID, TerminalPasteAction.LABEL, {
primary: KeyMod.CtrlCmd | KeyCode.KEY_V,
linux: { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_V },
// Don't apply to Mac since cmd+v works
mac: { primary: 0 }

@sbatten sbatten assigned Tyriar and unassigned sbatten Oct 22, 2019
@sbatten sbatten removed the bug Issue identified by VS Code Team member as probable bug label Oct 22, 2019
@Tyriar Tyriar added this to the October 2019 milestone Oct 22, 2019
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Oct 22, 2019
@Tyriar Tyriar closed this as completed in a9ce06c Oct 22, 2019
@Tyriar
Copy link
Member

Tyriar commented Oct 22, 2019

Works for me in the editor as well 🤷‍♂

Please open a new issue if that still happens on the latest insiders version

@JacksonKearl JacksonKearl added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@Tyriar @sbatten @JacksonKearl @PierreMarchand20