Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: decide what to do with galleryMachineIdResource #83215

Closed
bpasero opened this issue Oct 24, 2019 · 0 comments
Closed

Web: decide what to do with galleryMachineIdResource #83215

bpasero opened this issue Oct 24, 2019 · 0 comments
Assignees
@sandy081
Labels
debt Code quality issues web Issues related to running VSCode in the web
Milestone
April 2020

Comments

@bpasero
Copy link
Member

bpasero commented Oct 24, 2019 •
edited

The IEnvironmentService.galleryMachineIdResource is currently undefined in web but still being used from code that runs in web. Please decide what to do here, either move the usage to electron-browser/node layer or add it to web too.

Maybe a solution is to use the existing IEnvironmentService.machineId instead?
@bpasero bpasero added debt Code quality issues web Issues related to running VSCode in the web labels Oct 24, 2019
@sandy081 sandy081 added this to the November 2019 milestone Nov 18, 2019
@sandy081 sandy081 modified the milestones: November 2019, December 2019 Dec 2, 2019
@sandy081 sandy081 modified the milestones: January 2020, Backlog Jan 27, 2020
@sandy081 sandy081 modified the milestones: Backlog, April 2020 Apr 6, 2020
@sandy081 sandy081 mentioned this issue Apr 6, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues web Issues related to running VSCode in the web
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@bpasero @sandy081