Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ITerminalConfiguration #83261

Closed
Tyriar opened this issue Oct 24, 2019 · 0 comments
Closed

Clean up ITerminalConfiguration #83261

Tyriar opened this issue Oct 24, 2019 · 0 comments
Assignees
@Tyriar
Labels
debt Code quality issues terminal Integrated terminal issues
Milestone
October 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 24, 2019

I see keys that aren't used anymore

vscode/src/vs/workbench/contrib/terminal/common/terminal.ts

Line 116 in 5e4d7a8

experimentalBufferImpl: 'JsArray' | 'TypedArray';

@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Oct 24, 2019
@Tyriar Tyriar added this to the October 2019 milestone Oct 24, 2019
@Tyriar Tyriar self-assigned this Oct 24, 2019
@Tyriar Tyriar closed this as completed in 4035b05 Oct 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
1 participant
@Tyriar