Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: simple file dialog acts up in Firefox #83292

Closed
bpasero opened this issue Oct 25, 2019 · 3 comments
Closed

Web: simple file dialog acts up in Firefox #83292

bpasero opened this issue Oct 25, 2019 · 3 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox simple-file-dialog Issues with simple file dialog verified Verification succeeded web Issues related to running VSCode in the web
Milestone
October 2019

Comments

@bpasero
Copy link
Member

bpasero commented Oct 25, 2019

Steps to Reproduce:

  1. run web from Firefox
  2. File > Open...
  3. play around with typing paths and hit enter, the picker does not like that. The OK button does not seem to work either

image
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug simple-file-dialog Issues with simple file dialog web Issues related to running VSCode in the web firefox Issues running VSCode in Web on Firefox labels Oct 25, 2019
@alexr00 alexr00 added this to the October 2019 milestone Oct 25, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 29, 2019

Looks like a Firefox bug: https://stackoverflow.com/questions/33480562/firefox-document-execcommandinserttext
However, I can have better fallback behavior.

@alexr00
Copy link
Member

alexr00 commented Oct 29, 2019

Added better fallback, but it does mean that the undo buffer for the simple file dialog will be broken in Firefox and anywhere else that insertText doesn't work.

This was referenced Oct 30, 2019
Closed
Closed
@joaomoreno joaomoreno added the verified Verification succeeded label Oct 30, 2019
@joaomoreno
Copy link
Member

Thanks for this! 👏

@alexr00 alexr00 mentioned this issue Nov 28, 2019
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox simple-file-dialog Issues with simple file dialog verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @alexr00