Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: expanded find widget needs more height (Firefox) #83344

Closed
bpasero opened this issue Oct 26, 2019 · 1 comment
Closed

Web: expanded find widget needs more height (Firefox) #83344

bpasero opened this issue Oct 26, 2019 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox verified Verification succeeded web Issues related to running VSCode in the web
Milestone
October 2019

Comments

@bpasero
Copy link
Member

bpasero commented Oct 26, 2019

Steps to Reproduce:

  1. use Firefox
  2. expand the find widget to show replace

image

I would even say that in Chrome the border around the boxes is not the same to the bottom as it is to the top:

image
@bpasero bpasero added web Issues related to running VSCode in the web firefox Issues running VSCode in Web on Firefox labels Oct 26, 2019
@rebornix rebornix added this to the October 2019 milestone Oct 28, 2019
@rebornix
Copy link
Member

Thanks and good catch. FF has its own predefined css for textarea (margin top/bottom: 1px). Currently I disable it only for Find Widget as I didn't see any other component (Search, Git) suffers from it. If I do see that happening, then I'll force the margin for basic input component.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
2 participants
@rebornix @bpasero