Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: no longer show dirty indicator with "workbench.editor.highlightModifiedTabs": true #83416

Closed
bpasero opened this issue Oct 28, 2019 · 5 comments
Closed

Tabs: no longer show dirty indicator with "workbench.editor.highlightModifiedTabs": true #83416

bpasero opened this issue Oct 28, 2019 · 5 comments
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone
October 2019

Comments

@bpasero
Copy link
Member

bpasero commented Oct 28, 2019

Steps to Reproduce:

  1. Configure "workbench.editor.highlightModifiedTabs": true
  2. Make a file dirty

=> 馃悰 the dirty indicator does not show up anymore

image

Compared to stable:

image

I feel we had an issue in this area fixed but I think the rule is:

  • if the tab close button is visible we still show the dirty indicator even when this setting is on
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-tabs VS Code editor tab issues regression Something that used to work is now broken labels Oct 28, 2019
@bpasero bpasero added this to the October 2019 milestone Oct 28, 2019
@miguelsolorio
Copy link
Contributor

This is getting confusing. #83157 was created because the dot was visible when "workbench.editor.highlightModifiedTabs": true was set, so I fixed that but now that appears that this is not expected.

I will follow your rule as guidance and update verification steps for #64684.

@bpasero
Copy link
Member Author

bpasero commented Oct 28, 2019

Yeah sorry for that, unfortunately there are many settings involved for tabs.

@bpasero
Copy link
Member Author

bpasero commented Oct 28, 2019

Maybe best to quickly grab an old stable VSCode and compare how it behaves there with all the settings involved? E.g.:

  • tab close button visible/hidden
  • tab close button left/right
  • tab sizing shrink/fit
  • highlight modified tabs
  • tabs disabled

@miguelsolorio
Copy link
Contributor

Fixed and also verified in an older version of stable with the various settings from above:

image

@bpasero
Copy link
Member Author

bpasero commented Oct 28, 2019

Thanks!

@bpasero bpasero added the verified Verification succeeded label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
2 participants
@bpasero @miguelsolorio