Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Variable swatch in suggest widget has large gap #83461

Closed
miguelsolorio opened this issue Oct 28, 2019 · 3 comments
Closed

CSS Variable swatch in suggest widget has large gap #83461

miguelsolorio opened this issue Oct 28, 2019 · 3 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
October 2019

Comments

@miguelsolorio
Copy link
Contributor

image

We recently introduced a new icon container for the symbol icons in the suggest widget, not sure if this is affected by it but it's being added to the dom twice:

image
@miguelsolorio miguelsolorio added the bug Issue identified by VS Code Team member as probable bug label Oct 28, 2019
@octref octref added the suggest IntelliSense, Auto Complete label Oct 28, 2019
@octref octref added this to the October 2019 milestone Oct 28, 2019
@octref
Copy link
Contributor

octref commented Oct 28, 2019 •
edited

@jrieken I don't think this commit looks right: bd6c4a8

What do you think? I can put a quick fix here to make the iconContainer's class icon hide just for release, but I feel the DOM has become more complicated than it needs to be.

@jrieken
Copy link
Member

jrieken commented Oct 29, 2019

I trust you making the right call here 👍

@octref
Copy link
Contributor

octref commented Oct 29, 2019

Verifier: Complete color: i| in CSS. Verify you don't see the gap:

image

@octref octref closed this as completed in fb236dd Oct 29, 2019
@joaomoreno joaomoreno added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@joaomoreno @jrieken @octref @miguelsolorio