Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM statusbar contribution invisible until extension is activated #83464

Closed
kieferrm opened this issue Oct 28, 2019 · 4 comments
Closed

SCM statusbar contribution invisible until extension is activated #83464

kieferrm opened this issue Oct 28, 2019 · 4 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone
October 2019

Comments

@kieferrm
Copy link
Member

Issue Type: Bug

  1. open a folder that has changes in the remote (ensure SCM provider is not activated)
    -> Normally the statusbar indicates the incoming changes, but there is no Source Control status bar item. Also, the statusbar context menu, does not show teh Source Control entry.
  2. Open the SCM view
    -> statusbar item shows up

VS Code version: Code - Insiders 1.40.0-insider (33cc09d, 2019-10-28T11:46:25.634Z)
OS version: Darwin x64 18.7.0
Fetching remote diagnostics for 'vsonline+a9b3b743-0322-4bb5-8085-a84534b4a3c3' timed out.
Remote OS version: Linux x64 5.0.0-1022-azure
Remote OS version: Linux x64 5.0.0-1022-azure
Remote OS version: Linux x64 5.0.0-1022-azure

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.53GB free)
Process Argv -psn_0_2216477
Screen Reader no
VM 0%

Fetching remote diagnostics for 'vsonline+a9b3b743-0322-4bb5-8085-a84534b4a3c3' timed out.

Item Value
Remote SSH: az-devbox
OS Linux x64 5.0.0-1022-azure
CPUs Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz (4 x 2294)
Memory (System) 15.64GB (9.16GB free)
VM 0%
Item Value
Remote SSH: az-devbox
OS Linux x64 5.0.0-1022-azure
CPUs Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz (4 x 2294)
Memory (System) 15.64GB (9.16GB free)
VM 0%
Item Value
Remote SSH: az-devbox
OS Linux x64 5.0.0-1022-azure
CPUs Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz (4 x 2294)
Memory (System) 15.64GB (9.16GB free)
VM 0%
@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Oct 28, 2019
@joaomoreno joaomoreno added this to the October 2019 milestone Oct 29, 2019
@joaomoreno joaomoreno added the scm General SCM compound issues label Oct 29, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Oct 30, 2019 •
edited

Broken by #79566

@bpasero
Copy link
Member

bpasero commented Oct 30, 2019

@joaomoreno there is still that questionable check for file scheme in the code?

@joaomoreno
Copy link
Member

@bpasero Yeah you're right, let's clean that up as well.

joaomoreno added a commit that referenced this issue Oct 30, 2019
@joaomoreno
fixes #83464
dd8f21d
@joaomoreno
Copy link
Member

Verification:

  1. Open a git repo folder in VS Code
  2. Run Help: Welcome and pin that editor
  3. Reload the window

The git status bar contributions should appear

@bpasero bpasero added the verified Verification succeeded label Oct 31, 2019
@joaomoreno joaomoreno mentioned this issue Oct 31, 2019
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @kieferrm