Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Font Ligatures setting missing comment and not displayed as boolean #83491

Closed
gregvanl opened this issue Oct 29, 2019 · 5 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@gregvanl
Copy link

gregvanl commented Oct 29, 2019

  • VSCode Version: 1.40 Insiders
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open the Settings editor and search for "font".

Notice that the Editor: Font Ligatures settings is no longer shown as a boolean checkbox, has no description, and shows "Edit in settings.json".

Something may have been lost in a recent refactoring.

@gregvanl gregvanl added this to the October 2019 milestone Oct 29, 2019
@alexdima
Copy link
Member

This is intentional from the editor's side. The editor.fontLigatures setting can be: true, false, or a string. The string case is the advanced case where one can choose exactly which font features one wants from the font. Before, the setting could only be true or false.

I will leave it up to @roblourens to decide if the case true / false / freeform string is common enough such that we have rich UI in Settings for it or if it is advanced and must use manual editing of settings.json...

@alexdima alexdima assigned roblourens and unassigned alexdima Oct 29, 2019
@gregvanl
Copy link
Author

OK, then the issue is just that the setting doesn't have a description.

@roblourens
Copy link
Member

Not planning on supporting complex types like that right now. But it does need a description.

@roblourens roblourens assigned alexdima and unassigned roblourens Oct 29, 2019
@gregvanl
Copy link
Author

Looks like the EditorOption definition is missing a description at the outer object. Once the type is known, either boolean or string, there is an appropriate description on hover but there is nothing if the type isn't known.
There should be a general description of true, false, or the new advanced setting. This description will show up in the Settings editor, initial IntelliSense in settings.json (before the type is known), and the Default Settings (JSON).
Right now in Default Settings (JSON), the users sees an empty comment:

	// 
	"editor.fontLigatures": false,

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Oct 30, 2019
@joaomoreno joaomoreno added the verified Verification succeeded label Oct 30, 2019
@daryl-z
Copy link

daryl-z commented Nov 11, 2019

Change the value to string. "editor.fontLigatures": "true",

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants