Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Help > Report Issue" menu item added when product.json disables "reportIssueUrl" #83560

Closed
dalongi opened this issue Oct 29, 2019 · 0 comments · Fixed by #83561
Closed

"Help > Report Issue" menu item added when product.json disables "reportIssueUrl" #83560

dalongi opened this issue Oct 29, 2019 · 0 comments · Fixed by #83561
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues verified Verification succeeded
Milestone
October 2019

Comments

@dalongi
Copy link
Contributor

dalongi commented Oct 29, 2019 •
edited

  • VSCode Version: Built from Source
  • OS Version: OSX

Steps to Reproduce:

  1. Remove 'reportIssueUrl' from product.json
  2. Build VS Code from Source

Actual:

  • Menubar "Help" > "Report Issue" still shows in the top menu
  • Clicking "Report Issue" shows an error: "command 'workbench.action.openIssueReporter' not found"

Expected:

  • Menubar "Help" > "Report Issue" does not show when product.json disables issue reporting.

Does this issue occur when all extensions are disabled?: Yes
@dalongi dalongi mentioned this issue Oct 29, 2019
Merged
@RMacfarlane RMacfarlane added the issue-reporter Issue reporter widget issues label Oct 29, 2019
@RMacfarlane RMacfarlane self-assigned this Oct 29, 2019
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Oct 29, 2019
@RMacfarlane RMacfarlane added this to the October 2019 milestone Oct 29, 2019
RMacfarlane pushed a commit that referenced this issue Oct 29, 2019
@dalongi
Hide Help > Report Issue menu item when no reportIssueUrl in product.…
16ee963 
…json, fixes #83560
@joaomoreno joaomoreno added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

Successfully merging a pull request may close this issue.

Hide Help > Report Issue menu item when issue reporter is disabled in product.json dalongi/vscode
3 participants
@joaomoreno @dalongi @RMacfarlane