Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Number widget in settings GUI look bad #83572

Closed
octref opened this issue Oct 29, 2019 · 3 comments
Closed

Web: Number widget in settings GUI look bad #83572

octref opened this issue Oct 29, 2019 · 3 comments
Assignees
@roblourens @bpasero
Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox polish Cleanup and polish issue settings-editor VS Code settings editor issues verified Verification succeeded web Issues related to running VSCode in the web
Milestone
October 2019

Comments

@octref
Copy link
Contributor

octref commented Oct 29, 2019

Testing #83296:

Visual Studio Code - Insiders
Version: 1.40.0-insider
Commit: b7b2184
Date: 2019-10-29T06:38:51.389Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Settings editor - number widget looks bad with the default control on Firefox Linux:

image
@bpasero bpasero changed the title Test Web: Number widget in settings GUI look bad Web: Number widget in settings GUI look bad Oct 30, 2019
@bpasero bpasero added the web Issues related to running VSCode in the web label Oct 30, 2019
@bpasero bpasero assigned roblourens and unassigned bpasero Oct 30, 2019
@bpasero bpasero added polish Cleanup and polish issue settings-editor VS Code settings editor issues firefox Issues running VSCode in Web on Firefox labels Oct 30, 2019
@bpasero
Copy link
Member

bpasero commented Oct 30, 2019

//cc @misolori similar to the select dropdown issue we have

@roblourens
Copy link
Member

I think there is a css rule that is supposed to hide the custom controls

@roblourens roblourens added this to the November 2019 milestone Oct 30, 2019
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Oct 31, 2019
@bpasero bpasero self-assigned this Oct 31, 2019
@bpasero bpasero modified the milestones: November 2019, October 2019 Oct 31, 2019
@bpasero
Copy link
Member

bpasero commented Oct 31, 2019

Since I looked into this from #83556 I pushed a change.

@roblourens please note: b7e9344

@alexr00 alexr00 added the verified Verification succeeded label Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox polish Cleanup and polish issue settings-editor VS Code settings editor issues verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@roblourens @bpasero @octref @alexr00