Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled clear all notifications button changes color on click on some themes #83671

Closed
Tyriar opened this issue Oct 30, 2019 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 30, 2019

#61934

I do not reproduce that if we had this issue, it would surface for every disabled action item. Can you report this as new issue after checking that it reproduces elsewhere?

It does not surface in every action item, only that one. It reproduces with the Sapphire theme but not the built in ones. See the difference below, left is not clicked, right is clicked.

image

I think it's related to this rule:

.monaco-workbench a:active {
    color: inherit;
    background-color: inherit;
}

Toggling :active with devtools in <a class="action-label codicon codicon-clear-all disabled" role="button" title="Clear All Notifications" aria-disabled="true"></a> changes the color.

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Oct 30, 2019
@bpasero bpasero assigned miguelsolorio and unassigned bpasero Oct 30, 2019
@bpasero bpasero added the icons-product Issues for in-product icons label Oct 30, 2019
@bpasero
Copy link
Member

bpasero commented Oct 30, 2019

Moving to @misolori to check. I think this got introduced by using codicons.

@miguelsolorio miguelsolorio added this to the October 2019 milestone Oct 30, 2019
@Tyriar Tyriar added the verified Verification succeeded label Oct 30, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 30, 2019

Verified in 0f6fd4b

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants